[webkit-reviews] review granted: [Bug 5189] pcre_exec.c fails to compile using MSVC : [Attachment 4095] Separates int utf16Length declaration and assignment into 2 lines.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 30 07:37:46 PDT 2005


Darin Adler <darin at apple.com> has granted Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 5189: pcre_exec.c fails to compile using MSVC
http://bugzilla.opendarwin.org/show_bug.cgi?id=5189

Attachment 4095: Separates int utf16Length declaration and assignment into 2
lines.
http://bugzilla.opendarwin.org/attachment.cgi?id=4095&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Code change looks OK (but strange, amazing that MSVC has this bug), but patch
has a tab in it. Lets not add a tab to the file.



More information about the webkit-reviews mailing list