[webkit-reviews] review denied: [Bug 4874] Table with absolute bottom positioning is positioned incorrectly : [Attachment 3804] suggested patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Sep 27 13:48:17 PDT 2005


Dave Hyatt <hyatt at apple.com> has denied opendarwin.org at mitzpettel.com's request
for review:
Bug 4874: Table with absolute bottom positioning is positioned incorrectly
http://bugzilla.opendarwin.org/show_bug.cgi?id=4874

Attachment 3804: suggested patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3804&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
calcAbsoluteVerticalValue is only called for positioned elements.  Therefore as
far as I can tell, this line:

+    if (isTable() && (height.isVariable() || isPositioned()))

just reduces to

+ if (isTable())

I am not yet convinced that positioned tables under all circumstances are
supposed to shrink-to-fit.



More information about the webkit-reviews mailing list