[webkit-reviews] review granted: [Bug 4680] WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented" : [Attachment 3871] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 25 22:08:57 PDT 2005


Darin Adler <darin at apple.com> has granted Evan Gross <evan at rainmakerinc.com>'s
request for review:
Bug 4680: WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange
"not yet implemented"
http://bugzilla.opendarwin.org/show_bug.cgi?id=4680

Attachment 3871: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3871&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks fine, although I don't think we need to put the attributedString into a
local variable before returning it. (I'd probably just do this as a one-liner.)
r=me.



More information about the webkit-reviews mailing list