[webkit-reviews] review denied: [Bug 4821] Text in submitted forms should be entity-encoded if the current encoding doesn't support it : [Attachment 3937] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 4821: Text in submitted forms should be entity-encoded if the current
encoding doesn't support it
http://bugzilla.opendarwin.org/show_bug.cgi?id=4821

Attachment 3937: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3937&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks close, but should not be checked in as-is.

This code is not correct for the use of fromUnicode in KURL. Question marks
aren't correct either. I believe that we want to use %-escape sequences in the
KURL code. As Maciej said in his earlier comment, we should not make this
change to fromUnicode -- we should make it in a function used only by the form
code.