[webkit-reviews] review denied: [Bug 3442] CSS3: *-of-type selectors : [Attachment 2296] new patch, part 1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 24 03:09:42 PDT 2005

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3442: CSS3: *-of-type selectors

Attachment 2296: new patch, part 1

------- Additional Comments from Darin Adler <darin at apple.com>
The isElementNode() checks added on parent are unnecesssary. You can't have a
parent that's not an element.

The comment for PseudoLastOfType is the copied and pasted PseudoLastChild
comment, so it's wrong.

The formatting for the while () and if () don't match the coding style
guidelines as mentioned by Eric above.

The tagName locals should be AtomicString & rather than DOMString &, because
that way the == will be a simple pointer compare rather than a string compare.
In fact, hasTagName(xxx) should be used instead of tagName() == xxx.

I think this does look pretty good. Almost ready to go.

More information about the webkit-reviews mailing list