[webkit-reviews] review denied: [Bug 4940] CG and ATSUI give different width to the same text : [Attachment 3922] patch to implement the rounding hacks in the ATSUI code path

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 4940: CG and ATSUI give different width to the same text
http://bugzilla.opendarwin.org/show_bug.cgi?id=4940

Attachment 3922: patch to implement the rounding hacks in the ATSUI code path
http://bugzilla.opendarwin.org/attachment.cgi?id=3922&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
ATSULayoutParameters should not be in the header -- it's not used in any
declarations outside the file so it doesn't need to be.

Mitz said he'd remove the letter-spacing bits.

Is it right to use a copy of an ATSUTextLayout rather than a pointer in
ATSUTextLayoutParameters?

Please don't use ``'' quoting in WebKit code.

There should not be a space after the word initializeATSULayoutParameters and
before the opening parenthesis.

The overrideUPP should not be in a global variable. Since WebKit is never
compiled with CFM, the NewATSUDirectLayoutOperationOverrideUPP function is
simply