[webkit-reviews] review granted: [Bug 4898] Failures in dbaron's bidi ordering tests : [Attachment 4004] patch for embedding levels in bidi.cpp

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 23 09:07:55 PDT 2005


Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 4898: Failures in dbaron's bidi ordering tests
http://bugzilla.opendarwin.org/show_bug.cgi?id=4898

Attachment 4004: patch for embedding levels in bidi.cpp
http://bugzilla.opendarwin.org/attachment.cgi?id=4004&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looking this over makes me realize I really don't understand our bidi
algorithm. But on the other hand, it's all about the tests! And since Mitz is
our expert on this sort of thing, I think we should take this patch.

r=me



More information about the webkit-reviews mailing list