[webkit-reviews] review granted: [Bug 4394] Mouse clicks ignored in inline input areas : [Attachment 3879] updated patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 4394: Mouse clicks ignored in inline input areas
http://bugzilla.opendarwin.org/show_bug.cgi?id=4394

Attachment 3879: updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3879&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'd like to see the "DOM ranges intersect" code factored into a separate
function.

editableDOMRangeForPoint does always return a range with start == end. It uses
DOMRange just because there's no "DOMPoint".

I think this is a good change, r=me.

I'm concerned, however, that we don't have anyone testing the Japanese and
Chinese input methods. It's was quite challenging getting them working with
WebKit and Mail for Tiger, and I worry that changes in this area will result in
regressions in their behavior.