[webkit-reviews] review requested: [Bug 3742] Eyes don't render properly in acid2 test With Plugins disabled. : [Attachment 3992] Properly use images and fallback content

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 23 08:53:24 PDT 2005


Darin Adler <darin at apple.com> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 3742: Eyes don't render properly in acid2 test With Plugins disabled.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3742

Attachment 3992: Properly use images and fallback content
http://bugzilla.opendarwin.org/attachment.cgi?id=3992&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Patch has at least one tab in it. We indent using spaces, not tabs.

Does this do the right thing when display is "none"? I don't think it does
because rendererIsNeeded is supposed to return false in that case. Yet here was
are returning true just so that we can eventually get to the fallback content
code path.

I think part of the fix should be to move the plug-ins enabled check completely
out of rendererIsNeeded and instead do that check inside updateWidget.

I'd like Dave to review this.



More information about the webkit-reviews mailing list