[webkit-reviews] review requested: [Bug 5003] Add temporary "KDOM/KCanvas" Wrapper solution for SVG : [Attachment 4013] Updated patch which builds testkjs when necessary.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 22 14:49:55 PDT 2005


Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 5003: Add temporary "KDOM/KCanvas" Wrapper solution for SVG
http://bugzilla.opendarwin.org/show_bug.cgi?id=5003

Attachment 4013: Updated patch which builds testkjs when necessary.
http://bugzilla.opendarwin.org/attachment.cgi?id=4013&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Fixes build-webkit to make sure that testkjs is built when needed.  I'm still
(intentionally) ignoring the "All" build target, as this solution make for a
cleaner script which handles both JSC and JSC+SVG.  Once JSC+SVG goes away,
this could move back to an equally clean solution using the "All" target if
desired.

Really anyone could review this, darin reviewed the first iteration of this
patch.



More information about the webkit-reviews mailing list