[webkit-reviews] review denied: [Bug 4682] -[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text : [Attachment 3872] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Sep 20 16:59:24 PDT 2005


Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 4682: -[WebHTMLView firstRectForCharacterRange:] is using _selectedRange
instead of the given range if no marked text
http://bugzilla.opendarwin.org/show_bug.cgi?id=4682

Attachment 3872: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3872&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This strange behavior is necessary to make certain input methods work.

See Richard Williamson's 2005-03-23 check-in comment.

The problem reported was:

<TCIM> CangJie: the candidate window appears at the top left hand corner during
typing in Mail and iChat

1. Can be reproduced under setting : "Show Associated Words" chosen, Dynamic
Prompt chosen/not chosen, Candidate Window direction vertical/horizontal
2. Open Mail
3. Type ??? ( CangJie code: onf vnd rsqf)

* RESULTS
the candidate window appears at the top left hand corner. see attachment

We'll need to test this case if we want to change this function. Ironically,
the Radar bug has a comment from me saying:

"But this leaves the firstRectforCharacterRange method behaving very strangely,
and ignoring the range parameter passed in. We'll have to revisit this
eventually."



More information about the webkit-reviews mailing list