[webkit-reviews] review denied: [Bug 5003] Add temporary "KDOM/KCanvas" Wrapper solution for SVG : [Attachment 3933] New files for "wrapper" solution.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Sep 20 13:31:33 PDT 2005

Dave Hyatt <hyatt at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 5003: Add temporary "KDOM/KCanvas" Wrapper solution for SVG

Attachment 3933: New files for "wrapper" solution.

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Gave comments in person, but will re-summarize here:

(1) NodeTreeWrapper could be folded in to the DocumentImpl subclass.
(2) Check leaks... looks like some objects might be leaking here.
(3) Use QPainter in the paint() method instead of raw CG.
(4) paint() method will paint twice.  Make sure to only paint during the
foreground phase and not during other phases like the outline phase.
(5) Where are scripts handled?
Looks like they aren't.

More information about the webkit-reviews mailing list