[webkit-reviews] review denied: [Bug 5027] Decoder doesn't auto-detect XML encoded as UTF-16 if BOM is not present : [Attachment 3925] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Sep 19 15:56:00 PDT 2005


Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 5027: Decoder doesn't auto-detect XML encoded as UTF-16 if BOM is not
present
http://bugzilla.opendarwin.org/show_bug.cgi?id=5027

Attachment 3925: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3925&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
What's the argument for looking only at ptr[0] and not also at ptr[2], [4], and
[6]?

Otherwise, looks great!



More information about the webkit-reviews mailing list