[webkit-reviews] review requested: [Bug 3442] CSS3: *-of-type selectors : [Attachment 2296] new patch, part 1

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 17 14:21:04 PDT 2005


Eric Seidel <macdome at opendarwin.org> has asked Beth Dakin <bdakin at apple.com>
for review:
Bug 3442: CSS3: *-of-type selectors
http://bugzilla.opendarwin.org/show_bug.cgi?id=3442

Attachment 2296: new patch, part 1
http://bugzilla.opendarwin.org/attachment.cgi?id=2296&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
A couple comments:
1.  while ( n ), there shoudl be no space around the n, even though other parts
of the file do this, this is against the style guidelines:
http://webkit.opendarwin.org/blog/?page_id=25
Likewise the * goes next to the n, according to the guidelines.
Otherwise the code look sane.  But I don't have much context.



More information about the webkit-reviews mailing list