[webkit-reviews] review granted: [Bug 4892] Date constructor has problems with months larger than 11 : [Attachment 3868] Updated patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Mark Rowe (bdash)
<opendarwin.org at bdash.net.nz>'s request for review:
Bug 4892: Date constructor has problems with months larger than 11
http://bugzilla.opendarwin.org/show_bug.cgi?id=4892

Attachment 3868: Updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3868&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great. One complaint: The comment mentions CFGregorianDate overflow, but
that's only one reason to adjust the year and do %= on the month. The other is
to work best with the year offset machinery, and it applies even on
non-Mac-OS-X.