[webkit-reviews] review denied: [Bug 4892] Date constructor has problems with months larger than 11 : [Attachment 3858] Patch to wrap month around inside Date constructor, and Date.UTC.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 11 21:54:26 PDT 2005


Darin Adler <darin at apple.com> has denied Mark Rowe (bdash)
<opendarwin.org at bdash.net.nz>'s request for review:
Bug 4892: Date constructor has problems with months larger than 11
http://bugzilla.opendarwin.org/show_bug.cgi?id=4892

Attachment 3858: Patch to wrap month around inside Date constructor, and
Date.UTC.
http://bugzilla.opendarwin.org/attachment.cgi?id=3858&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This fix doesn't look right to me. I think handling things like this is part of
the job of the makeTime function, so we should fix that instead of doing this.



More information about the webkit-reviews mailing list