[webkit-reviews] review denied: [Bug 4394] Mouse clicks ignored in inline input areas : [Attachment 3862] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Sep 11 10:26:02 PDT 2005

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 4394: Mouse clicks ignored in inline input areas

Attachment 3862: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Patch looks great.

I don't think that the check for clcking outside the marked text is good
enough. To communicate the rectangle to the input manager, it's true that we
have to use only "first rect for character range", but for us internally, we
should be able to accurately determine if a click is in the marked text or not.
So the check should not be to get a rect and check if the mouse is in the rect.
Instead we should be passing the point over to WebCore to let it determine if
the click is outside the marked text.

Formatting nitpick: This code uses formatting like "NSEvent *", but the new
code says "NSInputManager*" with no space. I'd love for this to be consistent
across the entire WebKit project, either way. Unfortunately we have a mix.

More information about the webkit-reviews mailing list