[webkit-reviews] review denied: [Bug 4923] stop using <ostream> in WebCore, eliminating the <cmath> troubles it causes : [Attachment 3850] patch to remove the use of <ostream> and take out <math.h> workarounds

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 10 21:16:53 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 4923: stop using <ostream> in WebCore, eliminating the <cmath> troubles it
causes
http://bugzilla.opendarwin.org/show_bug.cgi?id=4923

Attachment 3850: patch to remove the use of <ostream> and take out <math.h>
workarounds
http://bugzilla.opendarwin.org/attachment.cgi?id=3850&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This breaks building under 4.0 (thus will break the opensource folks).	Also
please add back the 16 and 64 bit types, and qRound as otherwise WebCore+SVG
build will break when landing.	Otherwise the patch looks fine.



More information about the webkit-reviews mailing list