[webkit-reviews] review granted: [Bug 4849] htmltokenizer.cpp won't compile with TOKEN_DEBUG defined : [Attachment 3759] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Sep 7 08:19:39 PDT 2005


Darin Adler <darin at apple.com> has granted Mark Rowe (bdash)
<opendarwin.org at bdash.net.nz>'s request for review:
Bug 4849: htmltokenizer.cpp won't compile with TOKEN_DEBUG defined
http://bugzilla.opendarwin.org/show_bug.cgi?id=4849

Attachment 3759: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3759&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
It's really ugly that this includes calls to operator->, and the string is not
guaranteed to be contiguous, so it won't always work.

But on the other hand, at least it compiles. Maybe later we'll just remove all
this code.

r=me



More information about the webkit-reviews mailing list