[webkit-reviews] review denied: [Bug 4646] win portability fixes - misc files : [Attachment 3574] Makefile.vc

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Krzysztof Kowalczyk
<kkowalczyk at gmail.com>'s request for review:
Bug 4646: win portability fixes - misc files
http://bugzilla.opendarwin.org/show_bug.cgi?id=4646

Attachment 3574: Makefile.vc
http://bugzilla.opendarwin.org/attachment.cgi?id=3574&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'd like to know where the cases of the 3 warnings that are being suppressed
are. Maybe we can fix them instead of turning them off.

Also, the file contains a comment mentioning 4530.

You should remove the AVOID_STATIC_CONSTRUCTORS define -- we'd never want to
define that in a makefile.

The chartables.c thing should go away soon -- we're porting to a new version of
PCRE that doesn't need the giant table.

The DEBUG version should not set DEBUG_COLLECTOR by default. That's not
intended to be on by default.

Otherwise looks good as a first cut for the makefile. Would you be willing to
make the revisions and post a new version?