[webkit-reviews] review denied: [Bug 4789] so slow it feels like a hang calling UCFindTextBreak() tons of times at forum.presence-pc.com : [Attachment 3735] revised patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 3 17:41:53 PDT 2005


Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 4789: so slow it feels like a hang calling UCFindTextBreak() tons of times
at forum.presence-pc.com
http://bugzilla.opendarwin.org/show_bug.cgi?id=4789

Attachment 3735: revised patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3735&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I see one mistake here.

The code says "j == 0" where it should say "j == i".

Otherwise, this looks super-great!!



More information about the webkit-reviews mailing list