[webkit-reviews] review granted: [Bug 4781] Date.setMonth fails with big values due to overflow : [Attachment 3704] Fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 3 12:12:22 PDT 2005

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 4781: Date.setMonth fails with big values due to overflow

Attachment 3704: Fix

------- Additional Comments from Darin Adler <darin at apple.com>
The "containsNaN" function seems like it will go past even the 7th argument,
which is probably not the desired behavior. You probably want a maxArgs
parameter to that function. Also, that change doesn't seem to be part of the
bug fix. So maybe you should land it separately.

The main bug fix looks fine, r=me on that. I'm going to set this to review+,
but it's really review+ on the first half ot he patch and review- on the second

More information about the webkit-reviews mailing list