[webkit-reviews] review denied: [Bug 5514] Date conversion to local time gets the DST flag wrong for some dates : [Attachment 4506] Apply the realYearOffset hack only when absolutely necessary

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 5514: Date conversion to local time gets the DST flag wrong for some dates
http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

Attachment 4506: Apply the realYearOffset hack only when absolutely necessary
http://bugzilla.opendarwin.org/attachment.cgi?id=4506&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This line of code:

+const bool time_tIsSigned = isTime_tSigned();

will result in code run at load time. We don't allow that in JavaScriptCore and
WebCore. We'll need an alternate approach that does the same thing without a
global that requires executing code at library load time.