[webkit-reviews] review granted: [Bug 5404] fix createMarkup to support XML : [Attachment 4478] Patch addressing mjs's compatibility concerns.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Oct 25 22:11:39 PDT 2005


Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5404: fix createMarkup to support XML
http://bugzilla.opendarwin.org/show_bug.cgi?id=5404

Attachment 4478: Patch addressing mjs's compatibility concerns.
http://bugzilla.opendarwin.org/attachment.cgi?id=4478&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
It's strange to forward-declare a function inline as you do
doesHTMLForbidEndTag and shouldSelfClose. If the thing isn't defined until
after it's used, it won't get inlined, but if it's defined before it's used, it
doesn't need to be forward-declared.

Patch looks fine, r=me.



More information about the webkit-reviews mailing list