[webkit-reviews] review granted: [Bug 5409] slice() testcase doesn't pass : [Attachment 4466] Revised Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Oct 25 08:16:52 PDT 2005

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 5409: slice() testcase doesn't pass

Attachment 4466: Revised Patch

------- Additional Comments from Darin Adler <darin at apple.com>
There are a few examples here of braces for single lines. That doesn't match
our coding style. Also, I prefer just doing a return to setting the value of
String. Finally, I'd like test cases for what you fixed here.

But it looks good to me, so review+ anyway.

More information about the webkit-reviews mailing list