[webkit-reviews] review denied: [Bug 5479] Can't select text with RTL override rendered by ATSUI : [Attachment 4458] WebKit part of the patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 5479: Can't select text with RTL override rendered by ATSUI
http://bugzilla.opendarwin.org/show_bug.cgi?id=5479

Attachment 4458: WebKit part of the patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4458&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good. Will have to be merged with the change from methods to functions.

I have two questions:

1) I'm not entirely sure that roundf is the right thing to call for
selectedLeftX and backgroundWidth. Why rounding and not ceiling or floor?

2) I don't understand why the ATSUPositionToOffset workaround can be removed.