[webkit-reviews] review granted: [Bug 3275] Support Mozilla's XSLTProcessor JS object : [Attachment 4428] XLSTProcessor test cases

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Oct 22 08:46:15 PDT 2005

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3275: Support Mozilla's XSLTProcessor JS object

Attachment 4428: XLSTProcessor test cases

------- Additional Comments from Darin Adler <darin at apple.com>
I think that this:

+if (resultDocument != undefined)

isn't great code. You'd normally do if (resultDocument) or if (resultDocument
!= null).

In general I think we are using undefined in some places we should be using
null (in our code, not our test cases).

I'd like to see test cases that use namespace URIs, even if the test results
are "wrong", so we can detect changes to our behavior in those cases.

But this seems like a good start. r=me

More information about the webkit-reviews mailing list