[webkit-reviews] review granted: [Bug 5409] slice() testcase doesn't pass : [Attachment 4394] patch to fix slice() in KJS

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Oct 17 23:31:53 PDT 2005

Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 5409: slice() testcase doesn't pass

Attachment 4394: patch to fix slice() in KJS

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
George and I discussed how it would be safer against extreme values ot use
toInteger and leave things as double until after the range check, but I think
it's still an improvement to merge this fix from KJS.

More information about the webkit-reviews mailing list