[webkit-reviews] review denied: [Bug 5391] Need to merge with a more recent KSVG2 from kde : [Attachment 4382] Shared is now a Template class

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Oct 17 10:45:44 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Julien Palmas
<julien.palmas at gmail.com>'s request for review:
Bug 5391: Need to merge with a more recent KSVG2 from kde
http://bugzilla.opendarwin.org/show_bug.cgi?id=5391

Attachment 4382: Shared is now a Template class
http://bugzilla.opendarwin.org/attachment.cgi?id=4382&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This will need to be pulled over along with all the header changes which change
from:

class Foo : public Shared;

to:

class Foo : public Shared<Foo>;

Make sure you test the compile, and run-webkit-tests --svg.



More information about the webkit-reviews mailing list