[webkit-reviews] review denied: [Bug 5283] Standard anchor <a href="/"><img src="picrure.gif" /></a> does not work : [Attachment 4376] Patch that makes overflow lose to all other types of layers

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 16 23:59:33 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 5283: Standard anchor <a href="/"><img src="picrure.gif" /></a> does not
work
http://bugzilla.opendarwin.org/show_bug.cgi?id=5283

Attachment 4376: Patch that makes overflow lose to all other types of layers
http://bugzilla.opendarwin.org/attachment.cgi?id=4376&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I asked hyatt to make:

+	 bool layer1Overflow = layer1->renderer()->hasOverflowClip() && 
+			       !layer1->renderer()->isPositioned() &&
+			       !layer1->renderer()->isRelPositioned() &&
+			       !layer1->isTransparent();

into a single inline.

I also asked him to mark "compare" inline.

Finally, he noted that acid2 fails w/ this patch.  So review-.



More information about the webkit-reviews mailing list