[webkit-reviews] review denied: [Bug 5336] SVG with animation crashes WebKit+SVG : [Attachment 4359] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Oct 14 08:41:39 PDT 2005

Eric Seidel <macdome at opendarwin.org> has denied Julien Palmas
<julien.palmas at mac.com>'s request for review:
Bug 5336: SVG with animation crashes WebKit+SVG

Attachment 4359: Proposed patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This is a wonderful isolation of the problem.  We now know *what* is going
wrong, but not yet *why*.  This fix notices a symtom of the problem (that
somehow we have an animation setup pointing at a KDOM element instead of a
KSVG2 element) but does not answer the question why? and is "too late" a place
to fix.  We need to find out why this gets set up this way in the first place,
and make this check earlier.  "tit.key()" is typed SVGElementImpl, according to
the map... so the fact that something other than an SVGElementImpl got in there
is the bug, not that when pulling it out we didn't check correctly.  This is a
good start, but not the right fix yet.

More information about the webkit-reviews mailing list