[webkit-reviews] review requested: [Bug 5246] WebKit+SVG does not handle svgz properly : [Attachment 4300] First pass at svgz support

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Oct 10 14:50:06 PDT 2005


Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 5246: WebKit+SVG does not handle svgz properly
http://bugzilla.opendarwin.org/show_bug.cgi?id=5246

Attachment 4300: First pass at svgz support
http://bugzilla.opendarwin.org/attachment.cgi?id=4300&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
A patch from this weekend....

Basically this hacks the KHTMLPart to try to decode any data in the main
resource that looks like gzip.	I'm not sure this is the "best" way to do this,
but it works, and is a starting point for discussion.

There seems to also still be a race condition with the load, wherby sometimes
the document parse fails.  I'm probably getting an early 0 length write, and
should likely be keying my idea of "this is the first write" and thus
GZipInflater construction off of something other than the presence or absense
of d->m_decoder



More information about the webkit-reviews mailing list