[webkit-reviews] review denied: [Bug 5227] Array indexOf() extension for JavaScript 1.5 Core : [Attachment 4277] new patch, including the test case

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 9 22:10:25 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 5227: Array indexOf() extension for JavaScript 1.5 Core
http://bugzilla.opendarwin.org/show_bug.cgi?id=5227

Attachment 4277: new patch, including the test case
http://bugzilla.opendarwin.org/attachment.cgi?id=4277&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Darin notes on IRC we're missing at least a few more tests:

1.  where the array has more than one of the same value
2. where the target is another object using the array prototype
3. "===" rule vs. "==" rule.

The code looks fine.  Justin, please add these 3 more tests, and we'll land.



More information about the webkit-reviews mailing list