[webkit-reviews] review granted: [Bug 4974] Icons on top line disappear when window is resized : [Attachment 4276] patch with less whitespaces

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 9 20:41:22 PDT 2005

Dave Hyatt <hyatt at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 4974: Icons on top line disappear when window is resized

Attachment 4276: patch with less whitespaces

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me.  The other case where nearestFloatBottom is used was already correct.  

One oddity I noticed in the other code (not the patch) is that the other case
has the following if statement:

if (checkForBreak && (w + tmpW > width+1)) {

It checks for "width+1".  This is not how I remember writing the code
originally, and it doesn't look right to me. I will need to figure out who
patched this and why, since it doesn't look correct.

More information about the webkit-reviews mailing list