[webkit-reviews] review granted: [Bug 4142] Date object does not
always adjust daylight savings correctly : [Attachment 4271] Patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Oct 9 16:00:36 PDT 2005
Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 4142: Date object does not always adjust daylight savings correctly
http://bugzilla.opendarwin.org/show_bug.cgi?id=4142
Attachment 4271: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4271&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
What's the rationale for calling the local variable "t3"?
The FIXME says "on some systems", but this will happen on all systems; there's
no system where time_t has enough range to include all the years we want our
function to handle. So I suggest re-wording it. Otherwise, looks fine.
More information about the webkit-reviews
mailing list