[webkit-reviews] review granted: [Bug 5280] Date.setMonth fails with negative values : [Attachment 4263] alternate version of patch that uses _r versions of functions too (either one seems fine to me)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 9 13:33:07 PDT 2005


Maciej Stachowiak <mjs at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 5280: Date.setMonth fails with negative values
http://bugzilla.opendarwin.org/show_bug.cgi?id=5280

Attachment 4263: alternate version of patch that uses _r versions of functions
too (either one seems fine to me)
http://bugzilla.opendarwin.org/attachment.cgi?id=4263&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Using the _r versions is better. For platforms that don't have them, we can
solve it on a case-by-case basis.



More information about the webkit-reviews mailing list