[webkit-reviews] review granted: [Bug 5280] Date.setMonth fails
with negative values :
[Attachment 4254] handle negative month values in kjs::maketime
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Oct 8 11:11:13 PDT 2005
Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 5280: Date.setMonth fails with negative values
http://bugzilla.opendarwin.org/show_bug.cgi?id=5280
Attachment 4254: handle negative month values in kjs::maketime
http://bugzilla.opendarwin.org/attachment.cgi?id=4254&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
There really doesn't need to be a second branch. One case for negative numbers
and another for >= 0 would have been fine.
That having been said, this does look fine as-is. r=me
More information about the webkit-reviews
mailing list