[webkit-reviews] review denied: [Bug 5227] Array indexOf() extension for JavaScript 1.5 Core : [Attachment 4246] indexOf Compatible with Gecko

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Oct 7 18:05:49 PDT 2005


Darin Adler <darin at apple.com> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 5227: Array indexOf() extension for JavaScript 1.5 Core
http://bugzilla.opendarwin.org/show_bug.cgi?id=5227

Attachment 4246: indexOf Compatible with Gecko
http://bugzilla.opendarwin.org/attachment.cgi?id=4246&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'm sorry to be such a pain. This is nearly perfect, but...

+    if (args[1]->isUndefined() == false) {

The above should be !args[1]->isUndefined() -- we don't use == false for
booleans.

+    else
+	 searchElement = args[0];

The above should not include the optional else; since the if case returns
there's no need to have an else.

Otherwise, ready to go!



More information about the webkit-reviews mailing list