[webkit-reviews] review denied: [Bug 5227] Array indexOf() extension for JavaScript 1.5 Core : [Attachment 4236] indexOf Compatible with Gecko, addresses concerns made by mjs, fixes style issues

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 5227: Array indexOf() extension for JavaScript 1.5 Core
http://bugzilla.opendarwin.org/show_bug.cgi?id=5227

Attachment 4236: indexOf Compatible with Gecko, addresses concerns made by mjs,
fixes style issues
http://bugzilla.opendarwin.org/attachment.cgi?id=4236&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
There's a missing space after the first if before the "(" character. Must fix
that.

The right way to check if something is undefined is to use the isUndefined()
function rather than checking != explicitly against ConstantValues::undefined.
Probably OK this way, but not idiomatic.

The check of args[0] against undefined could just do an early return rather
than if/else. Just a suggestion: optional.