[webkit-reviews] review denied: [Bug 5266] Support parenthesized comments in Date.parse() : [Attachment 4209] allow comments where spaces are allowed

[bugzilla-request-daemon at opendarwin.org]

Geoffrey Garen <ggaren at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 5266: Support parenthesized comments in Date.parse()
http://bugzilla.opendarwin.org/show_bug.cgi?id=5266

Attachment 4209: allow comments where spaces are allowed
http://bugzilla.opendarwin.org/attachment.cgi?id=4209&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Nice catch on this bug.

I have two concerns:

1) I think your logic is wrong -- it doesn't seem to support dates of the form
"Wed (comment 1) (comment 2) Sep 28 2005", which FF does support. (Correct me
if I'm wrong - I haven't tested.)

2) The nesting of the &&'s and ||'s at the end is pretty confusing at first
glance. I think this might work better:
    while ((ch = *s++)) {
	if (ch == '(')
	    nesting++;
	else if (ch == ')')
	    nesting--;
	else if (!isspace(ch) && nesting == 0)
	    break;
    }