[webkit-reviews] review denied: [Bug 5175] Missing image for SVG
embedded in <object> tag in HTML document :
[Attachment 4202] patch that makes Webkit+svg render <object> tags with
image/svg+xml type
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Oct 4 22:13:46 PDT 2005
Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5175: Missing image for SVG embedded in <object> tag in HTML document
http://bugzilla.opendarwin.org/show_bug.cgi?id=5175
Attachment 4202: patch that makes Webkit+svg render <object> tags with
image/svg+xml type
http://bugzilla.opendarwin.org/attachment.cgi?id=4202&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
So a couple things.
1. We use spaces and not tabs, per:
http://webkit.opendarwin.org/blog/?page_id=25
2. We would need any SVG specific changes to KWQ to be inside SVG_SUPPORT
change blocks.
Otherwise this looks OK. We don't need any comments on this type of change.
It would be better to investigate why WebCoreImageRendererFactory allows this
as a MIME type though.
More information about the webkit-reviews
mailing list