[webkit-reviews] review granted: [Bug 5243] Numerous performance improvements to new FastMalloc to fix regression : [Attachment 4171] addressed darin's comments

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Oct 3 09:38:25 PDT 2005


Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 5243: Numerous performance improvements to new FastMalloc to fix regression
http://bugzilla.opendarwin.org/show_bug.cgi?id=5243

Attachment 4171: addressed darin's comments
http://bugzilla.opendarwin.org/attachment.cgi?id=4171&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Why remove the include of config.h from fpconst.cpp? It needs the definition of
WORDS_BIGENDIAN.

Otherwise looks fine. I'll mark review+, but please consider the fpconst.cpp
thing.



More information about the webkit-reviews mailing list