[webkit-reviews] review denied: [Bug 5195] Would like API to flush rendering of pending DOM changes : [Attachment 4119] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 2 20:32:35 PDT 2005

Darin Adler <darin at apple.com> has denied Duncan Wilcox <duncan at mclink.it>'s
request for review:
Bug 5195: Would like API to flush rendering of pending DOM changes

Attachment 4119: patch

------- Additional Comments from Darin Adler <darin at apple.com>
I still don't think this is quite right. We should not be overriding this
particular method, but rather the code path it follows that requires layout. In
particular, we want this to work properly even if you make the call directly on
the WebHTMLView.

Is there really a need to support repainting without relayout? I don't think
there is. Any painting should presumably create layout. The comment on the
ChangeLog indicates an idea that somehow we would paint but still wait for a
layout scheduling threshold; I think that's wrong.

More information about the webkit-reviews mailing list