[webkit-reviews] review denied: [Bug 5227] Array indexOf() extension for JavaScript 1.5 Core : [Attachment 4153] implements indexof

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 2 13:30:56 PDT 2005

Eric Seidel <macdome at opendarwin.org> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 5227: Array indexOf() extension for JavaScript 1.5 Core

Attachment 4153: implements indexof

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
We discussed this on IRC more.	this one fails to return correctly when value
not found.  I also suggested renaming index to indexFrom, and a cleaner way to
have the if statements.

More information about the webkit-reviews mailing list