[webkit-reviews] review denied: [Bug 5227] Array indexOf() extension for JavaScript 1.5 Core : [Attachment 4147] Fixes Complaints

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 2 12:29:23 PDT 2005

Eric Seidel <macdome at opendarwin.org> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 5227: Array indexOf() extension for JavaScript 1.5 Core

Attachment 4147: Fixes Complaints

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
As I said on IRC:

1.  Basically all of the comments should go away.  Comments rot even faster
than code.  The goal is to make your code as readable as possible.  If you ever
find it too long/too complex to be readable, we suggest using static inline
functions with descriptive names.

2.  if statements shoudl be broken into two lines, per our coding style

if (foo) doFoo();
should be
if (foo)

More information about the webkit-reviews mailing list