[webkit-reviews] review denied: [Bug 5227] Array indexOf() extension for JavaScript 1.5 Core : [Attachment 4147] Fixes Complaints

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 5227: Array indexOf() extension for JavaScript 1.5 Core
http://bugzilla.opendarwin.org/show_bug.cgi?id=5227

Attachment 4147: Fixes Complaints
http://bugzilla.opendarwin.org/attachment.cgi?id=4147&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
As I said on IRC:

1.  Basically all of the comments should go away.  Comments rot even faster
than code.  The goal is to make your code as readable as possible.  If you ever
find it too long/too complex to be readable, we suggest using static inline
functions with descriptive names.

2.  if statements shoudl be broken into two lines, per our coding style
guidelines:
http://webkit.opendarwin.org/blog/?page_id=25

if (foo) doFoo();
should be
if (foo)
    doFoo();