[webkit-reviews] review denied: [Bug 5227] Array indexOf() extension for JavaScript 1.5 Core : [Attachment 4139] Adds indexOf support to Array object

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Oct 1 23:20:58 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 5227: Array indexOf() extension for JavaScript 1.5 Core
http://bugzilla.opendarwin.org/show_bug.cgi?id=5227

Attachment 4139: Adds indexOf support to Array object
http://bugzilla.opendarwin.org/attachment.cgi?id=4139&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
-	   Every, ForEach, Some };
+		  Every, ForEach, Some, IndexOf };

Has tabs instead of spaces.  Please fix that first.

Also, please include your test case as part of the diff (make landing easier).

Also your if statements do not follow the coding guidlines (one line ifs have
no {}:
http://webkit.opendarwin.org/blog/?page_id=25

Please correct these small oversights and resubmit.  Thanks for the patch!



More information about the webkit-reviews mailing list