[webkit-reviews] review requested: [Bug 5875] WebCore+SVG fails to report errors, fails to load external scripts : [Attachment 4869] Addresses Darin's comments (XLinkNames broken out)

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 5875: WebCore+SVG fails to report errors, fails to load external scripts
http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Attachment 4869: Addresses Darin's comments (XLinkNames broken out)
http://bugzilla.opendarwin.org/attachment.cgi?id=4869&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
I addressed Darin's concerns regarding making the xlink qualified name (now
depends on 5887) as well as using SharedPtr to make sure that the ElementImpls
we create don't disappear out from underneath us.  After discussing with mjs
and darin, I did not attempt to abstract the ScriptElement logic into a common
baseclass for SVG & HTML at this time.	We may still chose to do so in the
future, but doing so is not critical at this moment.

Either Darin our Maciej should be able to review this.