[webkit-reviews] review requested: [Bug 5877] Remove remaining
APPLE_CHANGES and KHTML_NO_CPP_DOM blocks from WebCore :
[Attachment 4855] Responding to Darin's comments.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Tue Nov 29 14:59:30 PST 2005
Eric Seidel <macdome at opendarwin.org> has asked for review:
Bug 5877: Remove remaining APPLE_CHANGES and KHTML_NO_CPP_DOM blocks from
WebCore
http://bugzilla.opendarwin.org/show_bug.cgi?id=5877
Attachment 4855: Responding to Darin's comments.
http://bugzilla.opendarwin.org/attachment.cgi?id=4855&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
To address Darin's concerns, I did a couple things:
1. I did a search throughout the entire project looking for "excessive"
newlines and removed them.
2. I did a manual review of each of the previously changed files and removed
any extra comments, newlines.
3. I removed dom_misc.* entirely, and moved the remaining DOM::EventListener
and DOM::NodeFilterCondition onto khtml::Shared<T>
4. As part of my manual walk through khtml_part.cpp I removed
DIRECT_LINKAGE_TO_ECMA as well.
More information about the webkit-reviews
mailing list