[webkit-reviews] review denied: [Bug 5874] WebCore+SVG needs support for "evt" instead of event : [Attachment 4844] simple patch adding "evt" support

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Nov 29 07:29:19 PST 2005


Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 5874: WebCore+SVG needs support for "evt" instead of event
http://bugzilla.opendarwin.org/show_bug.cgi?id=5874

Attachment 4844: simple patch adding "evt" support
http://bugzilla.opendarwin.org/attachment.cgi?id=4844&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think a cleaner and clearer way to do this is to have a createSVGEventHandler
alternative to the createHTMLEventHandler function that follows the SVG rules
instead.

To control the parameter name used when constructing the event listener, I
suggest either adding a parameter to the JSLazyEventListener constructor or
creating derived classes specific to HTML and SVG.



More information about the webkit-reviews mailing list