[webkit-reviews] review granted: [Bug 5820] Table cells with
width:auto should use width from their <col> :
[Attachment 4791] Use <col> width during layout when necessary
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Nov 25 13:54:42 PST 2005
Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 5820: Table cells with width:auto should use width from their <col>
http://bugzilla.opendarwin.org/show_bug.cgi?id=5820
Attachment 4791: Use <col> width during layout when necessary
http://bugzilla.opendarwin.org/attachment.cgi?id=4791&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This looks just right to me. r=me
If it was me, I would have used a return rather than "w=" in
RenderTableCell::styleOrColWidth, but there are arguments that go both ways on
this very minor coding style issue.
It would be slightly better if RenderTableCell::calcMinMaxWidth() was written
so that it did not call styleOrColWidth() unless nowrap is set, but worrying
about this smacks of premature optimization.
More information about the webkit-reviews
mailing list